Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the facto -> a de facto #1653

Merged
merged 1 commit into from
Apr 21, 2021
Merged

the facto -> a de facto #1653

merged 1 commit into from
Apr 21, 2021

Conversation

michielbdejong
Copy link
Contributor

@michielbdejong michielbdejong requested a review from labkode as a code owner April 21, 2021 11:58
@update-docs
Copy link

update-docs bot commented Apr 21, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@michielbdejong
Copy link
Contributor Author

Given this is just a minor edit in the docs and not a code change, do you still want changelog entry about it? Happy to create one if you do! :)

1 similar comment
@michielbdejong
Copy link
Contributor Author

Given this is just a minor edit in the docs and not a code change, do you still want changelog entry about it? Happy to create one if you do! :)

ishank011
ishank011 approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@ishank011 ishank011 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michielbdejong looks good. For future reference, we have a list of tags for which we skip the changelog check. Currently this includes [build-deps] and [tests-only]. I'll add [docs-only] to the list as well

@ishank011 ishank011 merged commit aabac66 into master Apr 21, 2021
@michielbdejong michielbdejong deleted the de-facto-spelling branch April 22, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishank011 ishank011 ishank011 approved these changes

@labkode labkode Awaiting requested review from labkode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michielbdejong @ishank011